Add changes for better rendering of mermaid diagrams #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
reviewed
Dec 3, 2024
| @@ -82,7 +82,8 @@ class Reveal { | |||
| } | |||
|
|
|||
| nextSlide() { | |||
| return this.page.evaluate(_ => Reveal.next()); | |||
| this.page.evaluate(_ => Reveal.next()); | |||
| return this.page.evaluate(_ => Reveal.layout()); | |||
There was a problem hiding this comment.
I think this should be:
Suggested change
| return this.page.evaluate(_ => Reveal.layout()); | |
| return this.page.evaluate(_ => Reveal.next()).then(this.page.evaluate(_ => Reveal.layout())); |
WDYT?
astefanutti
reviewed
Dec 3, 2024
| @@ -82,7 +82,8 @@ class Reveal { | |||
| } | |||
|
|
|||
| nextSlide() { | |||
| return this.page.evaluate(_ => Reveal.next()); | |||
| this.page.evaluate(_ => Reveal.next()); | |||
| return this.page.evaluate(_ => Reveal.layout()); | |||
There was a problem hiding this comment.
I wonder if this is really needed to call it for every slide. Could you please check if calling it once in the configure method solve your issue?
There was a problem hiding this comment.
Will check, thx for the quick feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slight addition makes that mermaid diagrams are correctly rendered. They otherwise somehow end up below the page.